- dev-luatex - Mailing Lists

Bug for subsetted CFF font output
by Marcel Krüger 23 Oct '18

23 Oct '18

Hi, another bug in LuaTeX: If LuaTeX tries to calculate the size of a CFF table where the second entry in the table is a real number, `pack_real` is called with `work_buffer+i` for a small `i`. This causes aliasing issues because `work_buffer` writes into `work_buffer` using `sprintf`. So the output from `pack_real` modifies `work_buffer` before the digits are read completely, causing LuaTeX to complain about a "invalid character". An example to reproduce the issue: Run the following plainTeX document with the attached version of `LOGO10.otf` (the font was created by reordering the Private table entries and has an invalid checksum, but this is ignored by LuaTeX) \directlua{ font.current(font.define{ name='logo', embedding='subset', encodingbytes=2, format='opentype', filename='LOGO10.otf', characters={ [0x41] = { width = 1000, height = 1000, depth = 1000, index = 0x2, } }, }) } A \bye This can be fixed by adding a separate temporary buffer for `pack_real`: diff --git a/source/texk/web2c/luatexdir/font/writecff.c b/source/texk/web2c/luatexdir/font/writecff.c index cf0751179..1217d1a52 100644 --- a/source/texk/web2c/luatexdir/font/writecff.c +++ b/source/texk/web2c/luatexdir/font/writecff.c @@ -1171,6 +1171,7 @@ static long pack_integer(card8 * dest, long destlen, long value) static long pack_real(card8 * dest, long destlen, double value) { + static char temp_buffer[22]; long e; int i = 0, pos = 2; int res; @@ -1199,20 +1200,18 @@ static long pack_real(card8 * dest, long destlen, double value) e--; } } - res = sprintf(work_buffer, "%1.14g", value); + res = sprintf(temp_buffer, "%1.14g", value); if (res<0) normal_error("cff","invalid conversion"); - if (res>CFF_REAL_MAX_LEN) - res=CFF_REAL_MAX_LEN; for (i = 0; i < res; i++) { unsigned char ch = 0; - if (work_buffer[i] == '\0') { + if (temp_buffer[i] == '\0') { /*tex In fact |res| should prevent this. */ break; - } else if (work_buffer[i] == '.') { + } else if (temp_buffer[i] == '.') { ch = 0x0a; - } else if (work_buffer[i] >= '0' && work_buffer[i] <= '9') { - ch = (unsigned char) (work_buffer[i] - '0'); + } else if (temp_buffer[i] >= '0' && temp_buffer[i] <= '9') { + ch = (unsigned char) (temp_buffer[i] - '0'); } else { normal_error("cff","invalid character"); } @@ -1247,15 +1246,15 @@ static long pack_real(card8 * dest, long destlen, double value) pos++; } if (e != 0) { - sprintf(work_buffer, "%ld", e); + sprintf(temp_buffer, "%ld", e); for (i = 0; i < CFF_REAL_MAX_LEN; i++) { unsigned char ch = 0; - if (work_buffer[i] == '\0') { + if (temp_buffer[i] == '\0') { break; - } else if (work_buffer[i] == '.') { + } else if (temp_buffer[i] == '.') { ch = 0x0a; - } else if (work_buffer[i] >= '0' && work_buffer[i] <= '9') { - ch = (unsigned char) (work_buffer[i] - '0'); + } else if (temp_buffer[i] >= '0' && temp_buffer[i] <= '9') { + ch = (unsigned char) (temp_buffer[i] - '0'); } else { normal_error("cff","invalid character"); }

2 3

MetaPost get_... related problems
by Marcel Krüger 22 Oct '18

22 Oct '18

Hi, I noticed two problems with the mplib `get_...` family of functions: - First there seems to be a LuaTeX specific documentation bug: In the LuaTeX manual these functions are listed as `getboolean`, `getnumeric`, `getstring`and `getpath`, but in the actual implementation the names contain a underscore. - If `get_numeric` is called while two nested loops are in effect in MetaPost, an endless loop is triggered when MetaPost tries to iterate through the current loops. I attached a patch fixing both problems. The second point also applies to the standalone mplib. Best regards Marcel Krüger

2 4

Bug in \letcharcode
by Marcel Krüger 22 Oct '18

22 Oct '18

Hi, in the implementation of \letcharcode LuaTeX calls `set_token_info(cur_cs, cur_cs + cs_token_flag);`. This is weird, because the first argument to `set_token_info` is supposed to be a pointer to a one-word node as returned by `get_avail` and not a `cs`. I've got a document where this caused LuaTeX to overwrite a random token in a different macro every time `\letcharcode` was called. The active token isn't stored anywhere, so this can be fixed by just omitting `set_token_info`. Best regards Marcel Krüger Suggested patch: diff --git a/source/texk/web2c/luatexdir/tex/maincontrol.c b/source/texk/web2c/luatexdir/tex/maincontrol.c index 05e385b27..25acf1ea9 100644 --- a/source/texk/web2c/luatexdir/tex/maincontrol.c +++ b/source/texk/web2c/luatexdir/tex/maincontrol.c @@ -2698,9 +2698,7 @@ void prefixed_command(void) /*tex |letcharcode| */ scan_int(); if (cur_val > 0) { - cur_cs = active_to_cs(cur_val, true); - set_token_info(cur_cs, cur_cs + cs_token_flag); - p = cur_cs; + p = active_to_cs(cur_val, true); do { get_token(); } while (cur_cmd == spacer_cmd);

2 1

Missing opentype font entries in fls file
by Linas Stonys 02 Oct '18

02 Oct '18

Hi, I've noticed that there's no INPUT entries of any modern font (otf, ttf) in .fls file with TL2018. VERSION: This is LuaTeX, Version 1.07.0 (TeX Live 2018/W32TeX) (format=lualatex 2018.6.5) 2 OCT 2018 15:59 EXAMPLE - MYRIAD.TTF I put in local directory: \documentclass{article} \usepackage{fontspec} \setmainfont{lmroman10-regular.otf} \newfontfamily\myrfamily{MYRIAD.TTF} \begin{document} Abc def ghi {\myrfamily used myriad} \end{document} in the log file I see: <./MYRIAD.TTF><d:/texroot/2018/texmf-dist/fonts/opentype/public/lm/lmroman10-regular.otf> TL2016 with this small example acts the same but with larger file and "home made" class file I see INPUT lines but only with TL2016: INPUT C:/Users/lstonys/.texlive2016/texmf-vtex/luatex-cache/generic/fonts/otl/lmroman10-regular.luc INPUT d:/texroot/2016/texmf-dist/fonts/opentype/public/lm/lmroman10-regular.otf INPUT C:/Users/lstonys/.texlive2016/texmf-vtex/luatexja/extra_lmroman10-regular.luc ... INPUT C:/Users/lstonys/.texlive2016/texmf-vtex/luatex-cache/generic/fonts/otl/myriad.luc INPUT ./MYRIAD.TTF INPUT C:/Users/lstonys/.texlive2016/texmf-vtex/luatexja/extra_myriad.luc Could INPUT lines with used fonts appear in future texlive versions? Inputs from fls I use for making proper back up of project used files. Regards, Linas Stonys

1 0

Preserving unknown keys in cached font table
by Marcel Krüger 26 Sep '18

26 Sep '18

Hi, while looking into a [luaotfload bug][bug] caused by the fontloader being confused when LuaTeX overwrites the `parameters` in a cached font table, I wondered why `write_lua_parameters` always creates a new table instead of altering a potentially preexisting table. Changing this should lead to some small performance improvement because Lua no longer has to create a new table every time a cached font table is queried and more importantly it allows additional string keys in `parameters` to be preserved. Best regards Marcel [bug]: https://github.com/u-fischer/luaotfload/issues/3 A patch implementing the suggested change: --- source/texk/web2c/luatexdir/font/luafont.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/source/texk/web2c/luatexdir/font/luafont.c b/source/texk/web2c/luatexdir/font/luafont.c index e64aaffc1..68e74ffc5 100644 --- a/source/texk/web2c/luatexdir/font/luafont.c +++ b/source/texk/web2c/luatexdir/font/luafont.c @@ -349,7 +349,11 @@ static void write_lua_parameters(lua_State * L, int f) { int k; lua_push_string_by_name(L,parameters); - lua_newtable(L); + lua_pushvalue(L, -1); + if (LUA_TNIL == lua_rawget(L, -3)) { + lua_pop(L, 1); + lua_newtable(L); + } for (k = 1; k <= font_params(f); k++) { switch (k) { case slant_code: -- 2.19.0

3 7

Re: [Dev-luatex] luatex 1.08 in TL cannot be built with --with-system-gmp
by Norbert Preining 07 Sep '18

07 Sep '18

Reposting to dev-luatex, seems to be the appropriate place. On Thu, 06 Sep 2018, Norbert Preining wrote: > Hi Luigi, hi all, > > configuring current TL sources with > --with-system-gmp > I get an error: > gcc -DHAVE_CONFIG_H -I. -I../../../texk/web2c -I./w2c -I/usr/include/libpng16 -I/home/norbert/Development/TeX/texlive.git/Build/source/foo/texk -I/home/norbert/Development/TeX/texlive.git/Build/source/texk -I../../../texk/web2c/mplibdir -Wimplicit -Wreturn-type -g -O2 -MT libmplibcore_a-mpmathbinary.o -MD -MP -MF .deps/libmplibcore_a-mpmathbinary.Tpo -c -o libmplibcore_a-mpmathbinary.o `test -f 'mpmathbinary.c' || echo '../../../texk/web2c/'`mpmathbinary.c > In file included from ../../../texk/web2c/mplibdir/mpmathbinary.w:28: > ../../../texk/web2c/mplibdir/mpmathbinary.w:44:10: fatal error: gmp/config.h: No such file or directory > #include <gmp/config.h> > ^~~~~~~~~~~~~~ > compilation terminated. > > > Debian's libgmp-dev does not ship > gmp/config.h > only > gmp.h > > Is it now necessary to build with the TL shipped libgmp? Best Norbert -- PREINING Norbert http://www.preining.info Accelia Inc. + JAIST + TeX Live + Debian Developer GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13

2 2

luatex build breaks in current TL
by Norbert Preining 06 Sep '18

06 Sep '18

Hi Luigi, there are more breakages in TL since the inclusion of the current luatex sources (did anyone did test builds before committing???) Travis-CI complains since the last commits, error excerpt: gcc -DHAVE_CONFIG_H -I. -I../../../texk/web2c -I./w2c -I/texlive/Work/texk/ptexenc -I/texlive/texk/ptexenc -I/texlive/Work/texk -I/texlive/texk -Wimplicit -Wreturn-type -Wdeclaration-after-statement -Wno-unknown-pragmas -g -O2 -MT ptexdir/libkanji_a-kanji.o -MD -MP -MF ptexdir/.deps/libkanji_a-kanji.Tpo -c -o ptexdir/libkanji_a-kanji.o `test -f 'ptexdir/kanji.c' || echo '../../../texk/web2c/'`ptexdir/kanji.c mv -f ptexdir/.deps/libkanji_a-kanji.Tpo ptexdir/.deps/libkanji_a-kanji.Po make[5]: *** No rule to make target 'luatexdir/lua/helpers.w', needed by 'helpers.c'. Stop. make[5]: *** Waiting for unfinished jobs.... make[5]: Leaving directory '/texlive/Work/texk/web2c' Full log https://api.travis-ci.org/v3/job/425011985/log.txt Enjoy Norbert -- PREINING Norbert http://www.preining.info Accelia Inc. + JAIST + TeX Live + Debian Developer GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13

4 6

Re: [Dev-luatex] nodelist based tex.saveboxresource
by Hans Hagen 17 Aug '18

17 Aug '18

On 8/7/2018 7:23 AM, Marcel Krüger wrote: > ---- On Fri, 03 Aug 2018 15:51:24 +0200 Hans Hagen <j.hagen(a)xs4all.nl> wrote ---- > > On 8/3/2018 1:09 AM, Marcel Krüger wrote: > > > Hello, > > > > > > I want to suggest extending the tex.saveboxresource interface to accept a hlist or vlist node as an alternative to a box number as first argument. > > > Currently creating a boxresource from Lua node list requires saving the list in a TeX box register, only to delete that register again by tex.saveboxresource. > > > A direct way to transform a h/vlist into a boxresource would make such code easier and avoid potential side effects from changing the TeX registers. > > > An experimental patch with a suggested implementation is attached. > > > > ok, makes sense (but not entirely ok that way but i can fix it) > > > > > I also attached a patch implementing a node.scan method which I think would be another nice addition for LuaTeX: It scans a box with rules similar to `\setbox0` > > > and returns the node. This allows passing box-like material to LuaTeX without requiring box registers. > > > > this is tricky stuff so i need to have a close look at side effects > > (it's also more relatex to token scanning so belongs in another namespace) > > > > i'll have a go at it > > Thank you very much. Just so you know while testing the new changes I noticed that the current trunk generates a warning > > warning (pdf backend): dangling objects discarded > > for *every* non-empty document. I'm checking some backend issues and in the process that can happen. If trunk generates that then it's something else triggering it. Experimental is just that: experimental and things can change there stuff showing up there can even go. Also, if something is not documented, then don't use it. (This dangling is something i noticed and will be fixed, in addition to a possible accessor.) > Anyway there is another maybe more controversial feature I would like to see in LuaTeX: Could you add a callback replacing the built-in `do_delimiter`? > This would allow creating big delimiter in more flexible ways than just stacking boxes, especially I think about drawing custom-size delimiters using mplib > I am aware that this could be archieved by using the `mlist_to_hlist` callback but I think experimenting with delimiter construction should not require rewriting the entire mathlist conversion in Lua. Won't happen. For such fundamental extensions, changes, patches, adaptions one can use lua. In fact, drawing delimiters with e.g. mp can already be done for many years. It really makes no sense to replace each bit. We're now more than a decade in luatex and imo we can do whatever we want to extend in lua now. Also, given history it's nearly impossible to get an agreement on extensions that have hard coded behaviour. Probably the only bit that might evolve a bit is cleaning up the backend. (And I might start experimenting with a stripped down luatex follow up for context some day.) > Another option might be adding a `<function>` argument to node.mlist_to_hlist which, when not nil, is called to create delimiters. Won't happen either. Basically we're now at a stage where there will be no more extensions added. If needed there will be more parameters to replace hard coded values, but that's it. Hans ----------------------------------------------------------------- Hans Hagen | PRAGMA ADE Ridderstraat 27 | 8061 GH Hasselt | The Netherlands tel: 038 477 53 69 | www.pragma-ade.nl | www.pragma-pod.nl -----------------------------------------------------------------

2 6

Re: [Dev-luatex] nodelist based tex.saveboxresource
by Marcel Krüger 17 Aug '18

17 Aug '18

---- On Fri, 17 Aug 2018 10:08:13 +0200 Hans Hagen <j.hagen(a)xs4all.nl> wrote ---- > Hi, > > Just a note: you use experimental but experimental is actually there for > me and luigi as communication channel. It happens to be public but > that's a side effect. It's unsupported, and things can come and go. Thanks for the note. I mostly use a setup to easily switch between multiple installed versions, so I mostly use the last TeX Live version (or trunk) for anything important and only use experimental when experimenting, so things coming and going is not that much of a concern. But I keep this in mind and will also avoid writing to the list about the smaller bugs in there if it is that unsupported. Also thank you and luigi very much for all your great work on LuaTeX. Best regards Marcel

1 0

Fix PDF whatsits
by Marcel Krüger 14 Aug '18

14 Aug '18

Hello, I attached a little patch to avoid SEGFAULTs when the backend encounters `pdf_annot`, `pdf_start_link`, `pdf_dest` or `pdf_thread` whatsits. The SEGFAULT was introduced in revision 6738. I also noticed that there is no backend support for pdf_start_thread nodes, so using `\pdfextension startthread` leads to ! error: (pdf backend): no output function for whatsit pdf_start_thread Maybe a note about this could be added to the documentation? Best regards Marcel Krüger

2 1