- dev-luatex - NTG Mailing Lists

used_font always return false
by Marcel Fabian Krüger 21 Sep '19

21 Sep '19

Hi, the node(.direct).uses_font helpers currently always return false for glyph nodes: In the implementation static int lua_nodelib_direct_uses_font(lua_State * L) { halfword n = lua_tointeger(L,1); halfword f = lua_tointeger(L,2); halfword p; if (type(n) == glyph_node) { lua_pushboolean(L,font(n) == f); } else if (type(n) == disc_node) { uses_font_disc(pre_break,p,n); uses_font_disc(post_break,p,n); uses_font_disc(no_break,p,n); } /* todo: other node types */ lua_pushboolean(L,0); return 1; } the actual result is first calculated, but then the last pushboolean pushes a `false` on top of the stack and return this false. It could e.g. be fixed by adding a `return 1;` at the end of the first if block. `disc` nodes are not affected because uses_font_disc is a macro containing `return`. A minimal example in plain LuaTeX: \directlua{ local g = node.new'glyph' g.font = font.current() if not node.uses_font(g, font.current()) then error'This should not happen' end node.free(g) } \bye -- Marcel

4 5

Re: [Dev-luatex] Assignments in runtoks
by Marcel Fabian Krüger 05 Sep '19

05 Sep '19

On Mon, Sep 02, 2019 at 07:13:36PM +0200, luigi scarso wrote: > On Mon, Sep 2, 2019 at 10:59 AM Hans Hagen <j.hagen(a)xs4all.nl> wrote: > > > > > (I will send the patches to Luigi later today.) > > > > > ------------------------------------------------------------------------ > r7188 | luigi.scarso(a)gmail.com | 2019-09-02 19:12:22 +0200 (Mon, 02 Sep > 2019) | 1 line > > some cleanup + extra features runtoks (HH) > ------------------------------------------------------------------------ > This introduced a bug when `tex.runtoks` is called with a function: In ltexlib.c, runtoks function branch, token_info(r) is set twice and token_info(r) is never set. Also the first assignment to `token_info(t)` sets it to `token_val(end_local_code,0);`, but `end_local_code` is not a command code, so this becomes a space token. Also the supplied function is never called because the local call token is no longer inserted. -- Marcel

2 2

Assignments in runtoks
by Marcel Fabian Krüger 01 Sep '19

01 Sep '19

Hello, in current versions of LuaTeX, `runtoks` does not preserve token lists of ongoing assignments. Therefore running `runtoks` inside of `\edef` or similar replace the definition with the defined value of the last inner assignment. For example: \toks0{\def\innermacro{inner}} \edef\outermacro{outer\directlua{tex.runtoks(0)}} \show\outermacro \bye in plain TeX should show > \outermacro=macro: ->outer. but currently does show > \outermacro=macro: ->inner. instead. (As a side effect the reference count isn't updated, so for example \toks0{\def\innermacro{inner}\let\innermacro\undefined} \edef\outermacro{outer\directlua{tex.runtoks(0)}} \show\outermacro \bye starts printing hyphenation patterns on my system.) This can be fixed by saving scanner_status, warning_index and def_ref when entering local_control: diff --git a/source/texk/web2c/luatexdir/tex/maincontrol.c b/source/texk/web2c/luatexdir/tex/maincontrol.c index b01931dd1..284fb0ae3 100644 --- a/source/texk/web2c/luatexdir/tex/maincontrol.c +++ b/source/texk/web2c/luatexdir/tex/maincontrol.c @@ -1055,6 +1055,10 @@ extern void local_control_message(const char *s) void local_control(void) { int ll = local_level; + int save_scanner_status = scanner_status; + halfword save_def_ref = def_ref; + halfword save_warning_index = warning_index; + main_control_state = goto_next; local_level += 1; while (1) { @@ -1077,14 +1081,17 @@ void local_control(void) if (tracing_nesting_par > 2) { local_control_message("leaving due to level change"); } - return ; + break; } else if (main_control_state == goto_return) { if (tracing_nesting_par > 2) { local_control_message("leaving due to triggering"); } - return; + break; } } + scanner_status = save_scanner_status; + def_ref = save_def_ref; + warning_index = save_warning_index; return; }

3 5

Argument checking in ltexlib.c
by Marcel Fabian Krüger 23 Aug '19

23 Aug '19

Hello, in tex_setmathparm and tex_getmathparm from ltexlib.c, `i` stores the index of the math parameter to query or set. Given that `i` is obtained through luaL_checkoption it should never have a invalid value. The function still check that `i` is in the valid range using the check if (i<0 && i>=math_param_last) { /* invalid spec, just ignore it */ I think this is a typo because i>=math_param_last (with math_param_last=114) implies i>0 and therefore this condition can never be true. Maybe || could be used instead of && or the check could be removed entirly. Marcel

3 2

tex.{get,set}math argument names
by Marcel Fabian Krüger 22 Aug '19

22 Aug '19

Hello, in tex/texmath.c, the `math_param_names` array is missing the entries `skewedfractionvgap` and `skewedfractionhgap`. This causes all array indices to be shifted and therefore a mismatch between the parameter names in Lua and the real names. For example: \showthe\Umathlimitabovevgap\displaystyle \showthe\Umathskewedfractionvgap\displaystyle \directlua{ print('limitabovevgap:', tex.getmath('limitabovevgap', 'display')) print('skewedfractionvgap:', tex.getmath('skewedfractionvgap', 'display')) } \bye results in > 1.11111pt. l.1 \showthe\Umathlimitabovevgap\displaystyle ? > 0.0pt. l.2 \showthe\Umathskewedfractionvgap\displaystyle ? limitabovevgap: 0 [\directlua]:1: bad argument #1 to 'getmath' (invalid option 'skewedfractionvga p') -- Marcel

1 0

Re: [Dev-luatex] Embedding minimally used TTF fonts
by Marcel Krüger 23 Jul '19

23 Jul '19

On 23 July 2019 16:21:18 CEST, luigi scarso <luigi.scarso(a)gmail.com> wrote: >On Tue, Jul 23, 2019 at 1:03 PM Marcel Fabian Krüger <tex(a)2krueger.de> >wrote: > >> Hi, >> >> whenever LuaTeX loads a TTF font but only uses a single glyph, >> which happens to be the notdef glyph (GID=0), LuaTeX complains about >> >> (type 2): there are no glyphs in the subset >> >> Of course this isn't true, because the notdef *is* in the subset. >> >> This happens because LuaTeX always includes the notdef glyph, so it >is >> never counted. The problem can be fixed by explicitly testing for >this >> case. >> >> >Do you have an example ? Of course: \starttext \font\test=logix.ttf\test \char"F0000 \stoptext See https://github.com/u-fischer/luaotfload/issues/73 for some context.

2 2

Embedding minimally used TTF fonts
by Marcel Fabian Krüger 23 Jul '19

23 Jul '19

Hi, whenever LuaTeX loads a TTF font but only uses a single glyph, which happens to be the notdef glyph (GID=0), LuaTeX complains about (type 2): there are no glyphs in the subset Of course this isn't true, because the notdef *is* in the subset. This happens because LuaTeX always includes the notdef glyph, so it is never counted. The problem can be fixed by explicitly testing for this case. Best regards, Marcel Krueger diff --git a/source/texk/web2c/luatexdir/font/writetype2.c b/source/texk/web2c/luatexdir/font/writetype2.c index 49193579b..0f889f707 100644 --- a/source/texk/web2c/luatexdir/font/writetype2.c +++ b/source/texk/web2c/luatexdir/font/writetype2.c @@ -289,7 +289,7 @@ boolean make_tt_subset(PDF pdf, fd_entry * fd, unsigned char *buff, int buflen) num_glyphs++; } - if (num_glyphs == 1) { + if (num_glyphs == 1 && used_chars[0] == 0) { normal_error("type 2","there are no glyphs in the subset"); } if (tt_build_tables(sfont, glyphs, fd) < 0) {

1 0

linebreak_filter
by Marcel Fabian Krüger 20 Jul '19

20 Jul '19

Hi everyone, in current LuaTeX versions, the result of `linebreak` filter is ignored and instead it is always treated as if no node has been returned (so the internal linebreak algorithm is applied). A minimal example: \directlua{ callback.register("linebreak_filter", function(nodes) return node.hpack(nodes) end) } Some very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long paragraph. \bye You would expect the whole paragraph to be set in a single line, but normal paragraph breaking is applies instead. This is caused by a change in revision 6686 from Mar 29 2018 "experimental) possible fix for for lua stack issue + consistent error handling (HH)". There in the function lua_linebreak_callback, the change return ret; } + lua_settop(Luas, s_top); p = lua_touserdata(Luas, -1); if (p != NULL) { a = nodelist_from_lua(Luas); try_couple_nodes(*new_head,a); ret = 1; } - lua_settop(Luas, s_top); return ret; has been applied. I am not sure what kind of stack issue this was supposed to fix, but as a side effect this moves the check for the node return value after `lua_settop`, so the return value is already removed from the stack when the test is done. So it is ignored. Best regards, Marcel Krüger

2 3

luatex and harfbuzz 2.5.1
by luigi scarso 08 Jul '19

08 Jul '19

In experimental there is now luatex 1.11.0 with harfbuzz 2.5.1 It follows from the development of harftex by K. Hosny. Please note that the code is 1) in experimental 2) marked as work in progress so it can stay as is, it can be changed , it can be removed completely. We have relaxed the constrain "only C" so a recent C++ is required; but we keep the contrain on the size the must be "small" --- the current size of the binary is around 8M so still good. Feedbacks are welcome: it would be nice to have it in texlive 2020 modulo that constrains are satisfied. -- luigi

4 7

luatex 1.11: bfchar entry empty in mode=harf
by Ulrike Fischer 01 Jul '19

01 Jul '19

When I load a font in harf mode the bfchar entry is empty: \pdfvariable compresslevel0 \pdfvariable objcompresslevel0 \documentclass{article} \usepackage{harfload} %is actually in my format ... \begin{document} \font\test={texgyreheros:mode=harf;} abcäüö \end{document} gives in the pdf /CMapName /TeX-Identity-GXAFXV-LMRoman10-Regular def /CMapType 2 def 1 begincodespacerange <0000> <FFFF> endcodespacerange 0 beginbfrange endbfrange 0 beginbfchar endbfchar With harftex or an older luatex I get: 1 beginbfchar <0052> <0031> endbfchar What's going on here? -- Ulrike Fischer https://www.troubleshooting-tex.de/

3 8