[NTG-pdftex] [PATCH] pdftex - Add new \pdfpkscalable primitive

Pali Rohár pali.rohar at gmail.com
Sat Apr 15 05:49:23 CEST 2017


On Saturday 15 April 2017 01:18:44 Karl Berry wrote:
> I'm sorry, but I am not comfortable with releasing these changes for
> the Type 3 fonts + encoding + Unicode.  I realize the features now
> work in your cases, but I feel much more testing and understanding
> is needed, before inflicting changes to these low-level routines on
> the world. I can't undertake this for TL17.
> 
> The proximate cause is that, in some further testing, I discovered a
> case that crashed for me now, but did not crash before:
> \pdfmapline{<}

That is because in mapfile.c check_fm_entry() is missing check if 
tfm_name is not NULL.

Such thing is possible to hit also without my patches... And is not 
related to my patches.

Try:

\pdfmapline{<test.pfb}

and even on old TeX Live 2012 it crashed too:

../../../texk/web2c/pdftexdir/subfont.c:181: handle_subfont_fm: 
Assertion `fm->tfm_name != ((void *)0)' failed.

So it is there for a long time.

> Also, it's unclear to when the new warning
>   "invalid entry for `%s': encoding file for type3 missing"
> is intended to be given. I could not find any input that caused it.

That was added by Akira.

> I'm sure that it would not be hard to remedy these particular things,
> one way or another, but the general principle remains -- I'm simply
> too uneasy to release these changes, which have grown and grown. As
> I said before, the primary criterion for pdftex nowadays must be
> stability.
> 
> Unfortunately, in that testing, I also discovered other erroneous
> mapline cases that were already unhandled (before your patches). I
> know I have not found them all yet. Sigh.
> 
> If Thanh or Martin wants to include these changes in the upcoming
> release, and can help with testing/code review, then that is
> fine. Otherwise, it will have to wait for another time.
> 
> For the present, I have reverted the changes in the TL repository.
> (Hopefully correctly.)
> 
> At least you have written the code now, so can compile your own
> pdftex and use it for your own work ... --sorry, karl.

So what is needed for inclusion? More testing?

And do we have a case where pdftex behave incorrect (or crash) which is 
related to those toUnicode patches for PK fonts? Because I have not 
found any problem in current code yet and above crash (which you found) 
is there for a long time.

Do you want a fix for above crash?

-- 
Pali Rohár
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.ntg.nl/pipermail/ntg-pdftex/attachments/20170415/010df892/attachment.sig>


More information about the ntg-pdftex mailing list