[ pdftex-Bugs-719 ] few buglets in build.sh
Bugs item #719, was opened at 2007-01-01 22:39 You can respond by visiting: http://sarovar.org/tracker/?func=detail&atid=493&aid=719&group_id=106 Category: None Group: v1.40.0 Status: Open Resolution: None Priority: 5 Submitted By: Sanjoy Mahajan (sanjoy) Assigned to: Nobody (None) Summary: few buglets in build.sh Initial Comment: Just compiled 1.40.0 using build.sh. I had to make a few changes to get it to run on my system (Ubuntu 6.10, i386). The purpose of the chunks in the attached diff: 1. The JOBS variable wasn't used, so I changed its name be descriptive for parallel builds, and used it (and a related load variable) in the line that appends to the MAKE variable. Also, without the necessary double quotes around that line, the rest of the line after $MAKE is interpreted as a command rather than as stuff to append to MAKE (run build.sh with "--parallel" to see the problem). I used the short option names for make, to keep the line within 80 chars. 2. "-a build" is an (incomplete) AND statement, rather than a test for the "build" directory existing. The test should be "-e build" to check for existence. 3. Brace expansion is suboptimal in sh and not very portable to different reimplementations of sh. According to the bash man page: "Brace expansion introduces a slight incompatibility with historical versions of sh. sh does not treat opening or closing braces specially when they appear as part of a word, and preserves them in the output. Bash removes braces from words as a consequence of brace expansion. For example, a word entered to sh as file{1,2} appears identically in the output." I don't know the full story, but the fake sh on my system (actually 'dash') doesn't do brace expansion at all. And if the bash man page is right, even if it did the expansion, it wouldn't help since build.sh uses braces in the middle of a word. So I rewrote the two uses of brace expansion to avoid it. The resulting "build.sh --parallel" worked fine in my limited tests. It still complained that it couldn't find the texmf tree, but I figure that's okay since pdftex'll eventually (I hope) use kpathsea and texmf.cnf. -Sanjoy ---------------------------------------------------------------------- You can respond by visiting: http://sarovar.org/tracker/?func=detail&atid=493&aid=719&group_id=106
participants (1)
-
noreply@sarovar.org