Bug in mark to ligature handling
Marks don't get positioned correctly unless all marks are supplied, if one mark is omitted, the next mark will be positioned at the first anchor point, not in the second one etc, in some cases it'll even not positioned on the anchor point at all. In the attached sample, the first word in the line is correct, subsequent ones aren't. (The font used: http://raqm.googlecode.com/svn/trunk/fonts/simplenaskhi/SimpleNaskhi.ttf) Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer
Khaled Hosny wrote:
Marks don't get positioned correctly unless all marks are supplied, if one mark is omitted, the next mark will be positioned at the first anchor point, not in the second one etc, in some cases it'll even not positioned on the anchor point at all.
so, how are we supposed to know what marks are omitted Hans ----------------------------------------------------------------- Hans Hagen | PRAGMA ADE Ridderstraat 27 | 8061 GH Hasselt | The Netherlands tel: 038 477 53 69 | fax: 038 477 53 74 | www.pragma-ade.com | www.pragma-pod.nl -----------------------------------------------------------------
On Wed, Mar 04, 2009 at 09:37:26AM +0100, Hans Hagen wrote:
Khaled Hosny wrote:
Marks don't get positioned correctly unless all marks are supplied, if one mark is omitted, the next mark will be positioned at the first anchor point, not in the second one etc, in some cases it'll even not positioned on the anchor point at all.
so, how are we supposed to know what marks are omitted
The order of the marks/base letters are inserted in the text string should tell us, say we've a_b_c ligature, if the text string is "a b <mark1> c <mark2>", then we omitted the first mark in the, so <mark1> will be applied to the second anchor point and <mark2> to the third one. Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer
Khaled Hosny wrote:
Marks don't get positioned correctly unless all marks are supplied, if one mark is omitted, the next mark will be positioned at the first anchor point, not in the second one etc, in some cases it'll even not positioned on the anchor point at all.
In the attached sample, the first word in the line is correct, subsequent ones aren't. (The font used: http://raqm.googlecode.com/svn/trunk/fonts/simplenaskhi/SimpleNaskhi.ttf)
can you check the new beta? btw, use \starttext ... \stoptext and not \bye ----------------------------------------------------------------- Hans Hagen | PRAGMA ADE Ridderstraat 27 | 8061 GH Hasselt | The Netherlands tel: 038 477 53 69 | fax: 038 477 53 74 | www.pragma-ade.com | www.pragma-pod.nl -----------------------------------------------------------------
On Wed, Mar 04, 2009 at 12:48:36PM +0100, Hans Hagen wrote:
Khaled Hosny wrote:
Marks don't get positioned correctly unless all marks are supplied, if one mark is omitted, the next mark will be positioned at the first anchor point, not in the second one etc, in some cases it'll even not positioned on the anchor point at all.
In the attached sample, the first word in the line is correct, subsequent ones aren't. (The font used: http://raqm.googlecode.com/svn/trunk/fonts/simplenaskhi/SimpleNaskhi.ttf)
can you check the new beta?
It is fixed in the beta, thanks. Now I found another bug, when having two marks on the same base glyph, the first one is positioned correctly but not the second one. See the attached sample (I swapped the marks on the next word).
btw, use \starttext ... \stoptext and not \bye
Will do, thanks. Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer
Khaled Hosny wrote:
On Wed, Mar 04, 2009 at 12:48:36PM +0100, Hans Hagen wrote:
Khaled Hosny wrote:
Marks don't get positioned correctly unless all marks are supplied, if one mark is omitted, the next mark will be positioned at the first anchor point, not in the second one etc, in some cases it'll even not positioned on the anchor point at all.
In the attached sample, the first word in the line is correct, subsequent ones aren't. (The font used: http://raqm.googlecode.com/svn/trunk/fonts/simplenaskhi/SimpleNaskhi.ttf) can you check the new beta?
It is fixed in the beta, thanks.
Now I found another bug, when having two marks on the same base glyph, the first one is positioned correctly but not the second one. See the attached sample (I swapped the marks on the next word).
another attempt .. can you coordinate your tests with idris (he collects test snippets so that eventually we have some kind of regression test) Hans ----------------------------------------------------------------- Hans Hagen | PRAGMA ADE Ridderstraat 27 | 8061 GH Hasselt | The Netherlands tel: 038 477 53 69 | fax: 038 477 53 74 | www.pragma-ade.com | www.pragma-pod.nl -----------------------------------------------------------------
On Wed, Mar 04, 2009 at 03:14:17PM +0100, Hans Hagen wrote:
Khaled Hosny wrote:
On Wed, Mar 04, 2009 at 12:48:36PM +0100, Hans Hagen wrote:
Khaled Hosny wrote:
Marks don't get positioned correctly unless all marks are supplied, if one mark is omitted, the next mark will be positioned at the first anchor point, not in the second one etc, in some cases it'll even not positioned on the anchor point at all.
In the attached sample, the first word in the line is correct, subsequent ones aren't. (The font used: http://raqm.googlecode.com/svn/trunk/fonts/simplenaskhi/SimpleNaskhi.ttf) can you check the new beta?
It is fixed in the beta, thanks.
Now I found another bug, when having two marks on the same base glyph, the first one is positioned correctly but not the second one. See the attached sample (I swapped the marks on the next word).
another attempt ..
That one is fixed too, thanks. (Time to find another bug :) )
can you coordinate your tests with idris (he collects test snippets so that eventually we have some kind of regression test)
I uploaded the files in the svn repository with font: http://code.google.com/p/raqm/source/browse/#svn/trunk/fonts/simplenaskhi/te... Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer
On Wed, Mar 04, 2009 at 12:13:38AM +0200, Khaled Hosny wrote:
Marks don't get positioned correctly unless all marks are supplied, if one mark is omitted, the next mark will be positioned at the first anchor point, not in the second one etc, in some cases it'll even not positioned on the anchor point at all.
In the attached sample, the first word in the line is correct, subsequent ones aren't. (The font used: http://raqm.googlecode.com/svn/trunk/fonts/simplenaskhi/SimpleNaskhi.ttf)
I think I found another similar bug. In the attached file, the mark should have applied to index 4 not index 1 (since it comes after the last component in the ligature). BTW, thanks for \showotfcomposition command, it is very handy in "visually" debugging opentype fonts :) P.S. You need the latest version of the font to trigger this bug. Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer
participants (2)
-
Hans Hagen -
Khaled Hosny