Martin Schröder wrote:

2010/2/21 Taco Hoekwater :

...

I am curious how it works out for other people, as it is quite possible that I made a thinking error yet again.

You are all running systems with LANG=C, it seems...

[taco@ntg tmp]$ echo $LANG en_US.UTF-8 what's wrong?

Martin Schröder wrote:

2010/2/21 Taco Hoekwater :

...

[taco@ntg tmp]$ echo $LANG en_US.UTF-8

what's wrong?

You are in the Netherlands and speak Dutch. Why doesn't your computer? :-)

While at the computer, I 'speak' English a lot more than Dutch. Thanks for the patch. Best wishes, Taco

Taco Hoekwater wrote:

Martin Schröder wrote:

...

2010/2/21 Taco Hoekwater :

...

The script is source/texk/web2c/luatexdir/getluatexsvnrevision.sh, and it is currently run from build.sh and from the tools/luatextag script. The latter is used to create the source tarballs.

This uses svn info with an URL, which is SLOW. Wouldn't svnversion be the better tool to use?

But that commmand only works if there is a local repository.

But it may be the only option, sigh. As Mojca just pointed out: svn info URL doesn't know whether the local revision even remotely matches the URL's current revision. To make matters worse, 'svnversion' has a bad habit of returning something that is not a number at all, so it has to be parsed. I remain convinced that this aspect of subversion is simply broken by design. Best wishes, Taco

On Sun, Feb 21, 2010 at 06:13:11PM +0100, Taco Hoekwater wrote:

Taco Hoekwater wrote:

...

To make matters worse, 'svnversion' has a bad habit of returning something that is not a number at all, so it has to be parsed.

Now committed #3439. This is based on svnversion with a sed command to strip unwanted info and a preceding 'svn up' to make sure that svn agrees with itself.

And now I'm no longer able to build luatex: ../../../source/texk/web2c/luatexdir/luatex.c:22: error: expected expression before ‘;’ token ../../../source/texk/web2c/luatexdir/luatex.c: In function ‘runsystem’: ../../../source/texk/web2c/luatexdir/luatex.c:384: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result ../../../source/texk/web2c/luatexdir/luatex.c:386: warning: ignoring return value of ‘system’, declared with attribute warn_unused_result make[5]: *** [luatex-luatex.o] Error 1 (I'm using git-svn to track the repository rather than svn directly) Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer

On Sun, Feb 21, 2010 at 07:52:29PM +0100, Taco Hoekwater wrote:

Khaled Hosny wrote:

...

On Sun, Feb 21, 2010 at 06:13:11PM +0100, Taco Hoekwater wrote:

...

Taco Hoekwater wrote:

...

To make matters worse, 'svnversion' has a bad habit of returning something that is not a number at all, so it has to be parsed. Now committed #3439. This is based on svnversion with a sed command to strip unwanted info and a preceding 'svn up' to make sure that svn agrees with itself.

And now I'm no longer able to build luatex:

../../../source/texk/web2c/luatexdir/luatex.c:22: error: expected expression before ‘;’ token

This should have been fixed by #3440 (Patrick had the same problem)

I'm still getting this error with #3441. -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer

On Sun, Feb 21, 2010 at 08:42:33PM +0100, Patrick Gundlach wrote:

Hi,

...

...

...

../../../source/texk/web2c/luatexdir/luatex.c:22: error: expected expression before ‘;’ token

This should have been fixed by #3440 (Patrick had the same problem)

I'm still getting this error with #3441.

make sure you delete source/texk/web2c/luatexdir/luatex_svnversion.h.

Building fine now (without svn revision though, but this is expected). Thanks. -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font developer

Reinhard Kotucha wrote:

On 21 February 2010 Taco Hoekwater wrote:

...

Taco Hoekwater wrote:

...

To make matters worse, 'svnversion' has a bad habit of returning something that is not a number at all, so it has to be parsed.

Now committed #3439. This is based on svnversion with a sed command to strip unwanted info and a preceding 'svn up' to make sure that svn agrees with itself.

There is one difference to the former script, though. Because no directory is specified, the revision number you get is the highest one of the whole repository. This means that it is increased also if you don't change anything in the source tree but update trunk/manual.

Right. I fixed this a little bit differently, though. getluatexsvnversion.sh now assumes it is run inside source/, so it has "svnversion -c .", and build.sh does (cd source; ./texk/web2c/luatexdir/getluatexsvnversion.sh ) I did it like this because I cannot test relative paths in build.sh myself (and those build.sh files have had those relative paths since day one, also in pdftex) Best wishes, Taco

Mojca Miklavec wrote:

One idea (though I have no idea if it's doable or not): maybe it's possible to create before-commit or after-commit hook that automatically changes some configuration file in repository after every commit and writes commit number to that file. Consequently the build should not depend on the existence of local svn repository.

I fear that there are two problems with that approach: 1. it meeds server-side scripting 2. each commit then has to be followed by an explicit svn co to fetch the newly updated file, otherwise the client does not know it has changed. Best wishes, Taco