255 characters limit on font names
Hi all, Currently fonts with names are longer than 255 characters are ignored and the font fails to load without an explanation. See https://github.com/lualatex/luaotfload/issues/424 for background. The code suggests this is a limitation of the DVI format (the relevant check was add back in 2009 according to repository history), but it shouldn’t affect PDF mode. The attached patch restricts the check to DVI mode and adds an error message. Alternatively the font name can be just truncated in DVI mode (which what happens if the check is removed, but the extra characters are removed from the start of the name, no idea why) an just issue a warning, or use the file name for DVI format since the rest of the spec is irrelevant to DVI files (but this can be debatable, I don’t know if there are any DVI drivers that can parse LuaTeX font names and load the fonts). Regards, Khaled
On Tue, Nov 13, 2018 at 5:19 PM Khaled Hosny
Hi all,
Currently fonts with names are longer than 255 characters are ignored and the font fails to load without an explanation. See https://github.com/lualatex/luaotfload/issues/424 for background. The code suggests this is a limitation of the DVI format (the relevant check was add back in 2009 according to repository history), but it shouldn’t affect PDF mode.
Thank you for the report, we are seeing it now. -- luigi
On Tue, Nov 13, 2018 at 6:15 PM luigi scarso
On Tue, Nov 13, 2018 at 5:19 PM Khaled Hosny
wrote: Hi all,
Currently fonts with names are longer than 255 characters are ignored and the font fails to load without an explanation. See https://github.com/lualatex/luaotfload/issues/424 for background. The code suggests this is a limitation of the DVI format (the relevant check was add back in 2009 according to repository history), but it shouldn’t affect PDF mode.
Thank you for the report, we are seeing it now.
Committed r6998. -- luigi
On Tue, Nov 13, 2018 at 11:04:10PM +0100, luigi scarso wrote:
On Tue, Nov 13, 2018 at 6:15 PM luigi scarso
wrote: On Tue, Nov 13, 2018 at 5:19 PM Khaled Hosny
wrote: Hi all,
Currently fonts with names are longer than 255 characters are ignored and the font fails to load without an explanation. See https://github.com/lualatex/luaotfload/issues/424 for background. The code suggests this is a limitation of the DVI format (the relevant check was add back in 2009 according to repository history), but it shouldn’t affect PDF mode.
Thank you for the report, we are seeing it now.
Committed r6998.
Thanks. Regards, Khaled
participants (2)
-
Khaled Hosny
-
luigi scarso