T T wrote:
On 15 March 2010 07:47, Taco Hoekwater
wrote: T T wrote:
I would also suggest to remove the 'svn up' from the script. While working on/testing local changes you do not necessarily want to keep the working copy in sync with the head. And perhaps Perhaps the call to getluatexsvnversion.sh should be an explicit option for build.sh instead of implied, but I prefer the rev. number to reflect the actual state of the repository, so I would like to leave the svn up command in it.
This is just a suggestion, but I think that the decision whether to svn up or not should be configurable somehow. There might be justified reasons why one doesn't want to do that (e.g. svn doesn't work for me here because of proxy -- every time it stalls until timeout making it quite annoying).
Oh, alright then. Patch applied (#3494) Best wishes, Taco