Re: [dev-context] patch: \definegraphictypesynonym

On Thu, 6 Aug 2015, Hans Hagen wrote:

On 8/6/2015 3:02 AM, Brian R. Landy wrote:

...

...

On Aug 5, 2015, at 5:55 PM, Hans Hagen wrote:

On 8/5/2015 10:12 PM, Brian R. Landy wrote:

...

Hi, I noticed on recent betas (I'm not sure when this first began) that the command \definegraphictypesynonym no longer works. I corrected it in grph-inc.lua:

--- a/tex/texmf-context/tex/context/base/grph-inc.lua +++ b/tex/texmf-context/tex/context/base/grph-inc.lua @@ -429,8 +429,8 @@ end function figures.registersuffix (suffix, target) register('list', target,suffix ) end function figures.registerpattern(pattern,target) register('pattern',target,pattern) end

-implement { name = "registerfiguresuffix", actions = register, arguments = { "'list'", "string", "string" } } -implement { name = "registerfigurepattern", actions = register, arguments = { "'pattern'", "string", "string" } } +implement { name = "registerfiguresuffix", actions = figures.registersuffix, arguments = { "string", "string" } } +implement { name = "registerfigurepattern", actions = figures.registerpattern, arguments = { "string", "string" } }

I believe I only needed to fix "registerfiguresuffix" but also patched "registerfigurepattern" since the code looks like it isn't working, either. This was tested on 20150805.

Are you sure about this? Can you give an example where the original fails?

local function register(tag,target,what) print(">>",tag,target,what) local data = figures_formats[target] -- resolver etc

can be uses for testing

Hans

----------------------------------------------------------------- Hans Hagen | PRAGMA ADE Ridderstraat 27 | 8061 GH Hasselt | The Netherlands tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com | www.pragma-pod.nl ----------------------------------------------------------------- _______________________________________________ dev-context mailing list dev-context@ntg.nl http://www.ntg.nl/mailman/listinfo/dev-context

I copied the sample cow.pdf into the local directory as cow_brl.brl, and saved the below as test.tex. The resulting pdf is attached. With my patch the graphic is included.

\definegraphictypesynonym[brl][pdf] \starttext \externalfigure[cow_brl] \stoptext

we need to swap target in the reghister function: M

local function register(tag,what,target)

function figures.registersuffix (suffix, target) register('list',suffix,target) end function figures.registerpattern(pattern,target) register('pattern',pattern,target) end

then the implementers are ok

Hans

----------------------------------------------------------------- Hans Hagen | PRAGMA ADE Ridderstraat 27 | 8061 GH Hasselt | The Netherlands tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com | www.pragma-pod.nl -----------------------------------------------------------------

Yes, that takes care of the problem as well. Thanks. Best regards, Brian